Skip to content

Correctly set metrics tags for unknown issuer #18926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Correctly set metrics tags for unknown issuer #18926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed7ed3
Correctly set metrics tags for unknown issuer
di Oct 23, 2025
e91be2d
Merge branch 'main' into fix-unknown-issuer-metrics-tags
miketheman Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/unit/oidc/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,12 @@ def body(self):
assert isinstance(err, dict)
assert err["code"] == "invalid-payload"
assert err["description"] == "unknown trusted publishing issuer"
assert metrics.increment.calls == [
pretend.call(
"warehouse.oidc.mint_token_from_oidc.unknown_issuer",
tags=["issuer_url:nonexistent-issuer"],
)
]


@pytest.mark.parametrize(
Expand Down
2 changes: 1 addition & 1 deletion warehouse/oidc/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def mint_token_from_oidc(request: Request):
if not service_name:
request.metrics.increment(
"warehouse.oidc.mint_token_from_oidc.unknown_issuer",
tags={"issuer_url": unverified_issuer},
tags=[f"issuer_url:{unverified_issuer}"],
)
return _invalid(
errors=[
Expand Down