feat: add Fit Mode to Context Menu #1698
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.22% // Head: 66.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
+ Coverage 66.22% 66.26% +0.04%
==========================================
Files 164 165 +1
Lines 5441 5464 +23
Branches 1220 1224 +4
==========================================
+ Hits 3603 3620 +17
- Misses 1831 1837 +6
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/create-server |
| return ( | ||
| <MenuItem key="fit-mode" onClick={handleClick}> | ||
| {/* todo: add icons */} | ||
| Fit mode: {isHeadFirst ? 'tail first' : 'heat first'} |
There was a problem hiding this comment.
| Fit mode: {isHeadFirst ? 'tail first' : 'heat first'} | |
| Fit mode: {isHeadFirst ? 'tail first' : 'head first'} |
Although since we have enough space, I think we can be more explicit Fit {head, tail} first or or some better wording cc @Rperry2174
There was a problem hiding this comment.
I think the wording is fine, but for consistency we should add the icon the same way the other options have an icon
There was a problem hiding this comment.
absolutely..which one should i use ?
There was a problem hiding this comment.
Lets use the same icons from the toolbar (depending on whether it says "head" or "tail" first. As far as the text for the other ones we kind of explain what happens with the option:
What do you guys think about:
- "[ Icon ] Show text head first"
- "[ Icon] Show text tail first"
There was a problem hiding this comment.
looks good i think
Screen.Recording.2022-11-14.at.11.04.11.mov
…nt/index.tsx Co-authored-by: eduardo aleixo <eh-am@users.noreply.github.com>
|
/create-server |
|
/create-server |
|
Looks good! Thanks |
5 participants
Brief
Changes
demo link: https://pr-1698.pyroscope.io/?name=hotrod.python.frontend%7B%7D&query=rideshare-app-golang.cpu%7B%7D
Screen.Recording.2022-11-10.at.14.59.14.mov
Concerns