fix: delete app also deletes metadata #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Codecov ReportBase: 66.59% // Head: 66.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
- Coverage 66.59% 66.21% -0.37%
==========================================
Files 169 169
Lines 5563 5560 -3
Branches 1260 1258 -2
==========================================
- Hits 3704 3681 -23
- Misses 1849 1869 +20
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eh-am
changed the title
Collaborator
kolesnikovae
left a comment
kolesnikovae
left a comment
There was a problem hiding this comment.
Looks just great :) I left a couple of notes – nothing really important but give them a look please
korniltsev
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
ApplicationServicethat bridgesApplicationMetadataServiceandStorage.The operations
List,Get,Createare relayed toApplicationMetadataServiceonly.Now
Deleteis relayed to bothApplicationMetadataServiceANDStorage. This is so that when one is deleting an App, it must be deleted from storage but ALSO be deleted from the metadata database. Otherwise the application will still be shown in the application dropdown.Also moved handlers code to
/apito keep things consistent with the new way we are managing these handlers.Although there are no tests there (they are still in the admin package)