Skip to content

Conversation

@ilia-kats
Copy link

No description provided.

@jmarshall
Copy link
Member

jmarshall commented Oct 9, 2024

Thanks for your PR, which is fairly comprehensively done. I wanted to fix the fclosing-stdout thing a different way (by not closing it in samtools/bamtk.c.pysam.c), and it has now been superseded by PR #1310, which imports 1.21.

(Incidentally pysam.sort("-n", …) has always sorted by name; SAMtools v1.19 merely introduced -N with a slightly different name-sorted sort order.)

@jmarshall jmarshall closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants