'Fix' test_targeted_stdio_async
#1316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffersGlass
added
tag: tests
Member
|
@JeffersGlass I think we can close this since #1319 is already merged, what say? |
Contributor
Author
|
Yep, this ended up being redundant. Thanks @madhur-tandon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may never need to be actually merged - it's more a description of the "new" behavior of coroutines after #1258 and what I found.
"Fixes" the
test_targeted_stdio_asynctest that was broken by the syncify PR. I say fixes because, while I think the included comments correctly describe the current behavior on the Python side, I don't think I've fully thought through how they interact with the new way everything is await-ed on the JS side. Hence the WIP.Address #1314, but does not close it, as there is another test to fix.