Skip to content

Conversation

@mrbean-bremen
Copy link
Member

  • real directory contents are only added to the fake file system on
    demand (makes adding large directory trees faster)
  • refactored real file/directory access to use own classes

- real directory contents are only added to the fake file system on
demand (makes adding large directory trees faster)
- refactored real file/directory access to use own classes
@mrbean-bremen mrbean-bremen requested a review from jmcgeheeiv May 16, 2017 21:17
@mrbean-bremen
Copy link
Member Author

mrbean-bremen commented May 16, 2017

I use tox locally, which creates the virtual environments for all versions in a .tox directory under pyfakefs. This led to one of the unit tests (real directory tree) to run about 10 seconds for each python version, as it enumerated all files in these directories recursively. So I decided to add lazy evaluation also for real directory contents...
This will be my last change for now (if no bug comes in), so after that you can go ahead with the release if you want.

- may be needed for tests that check the disk usage to avoid the side effect of changing disk usage during delayed directory content access
@jmcgeheeiv jmcgeheeiv merged commit de0d107 into pytest-dev:master May 23, 2017
@jmcgeheeiv
Copy link
Contributor

Wow. Big job.

@mrbean-bremen mrbean-bremen deleted the lazy-real-dir branch May 27, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants