-
Notifications
You must be signed in to change notification settings - Fork 172
Packaging and testing cleanups #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For the failing test, I suggest making tests/async_fixtures/test_async_gen_fixtures_35.py collectable only for 3.5 (the refactor removed async_generator as a test dependency, which I think is the right move). |
|
No, the accidental removal of async_generator as testing dependency was a mishap. I will add it back. Such generators must be usable from Python 3.6+ and should also be tested that way. |
9623d47 to
ff287f4
Compare
|
I'd say 3.6+ should just use normal async generators, no? |
|
And if you're running 3.5 compatible code on 3.6? |
|
Let me rephrase: test code written for 3.5 should be runnable on 3.6 too, and the inclusion of |
|
Right, you have a point. I don't see the harm including it in the test requirements in any case. |
|
One last thing: I see you removed the metadata section from setup.cfg. Is the license file still being included in the wheel? I had an explicit request for this from a downstream repackager. |
|
I see no references to such functionality in setuptools or wheel. Nor have I seen this anywhere else. Can you point me to documentation that says this is a thing? |
|
Right, it's kinda obscure. Here's a link, search for 'metadata' inside: https://hynek.me/articles/sharing-your-labor-of-love-pypi-quick-and-dirty/ You can test it out yourself, wheels are zips. The license should be in there after |
|
Seems like an undocumented option. I'll put it back. |
ff287f4 to
cd09218
Compare
|
Note that the official wheel documentation says the following:
|
|
Thanks! |
Mostly cosmetic simplifications and improvements in the testing and packaging setup.
Highlights:
testingextras (pip install -e .[testing])python_requiresto packaging metadata