-
Notifications
You must be signed in to change notification settings - Fork 253
Allow opening generated html report in browser #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By default terminals would open files in editors and URLs in browsers. By printing the generated html report using an URL (file://) we enable users to click the terminal to open it. Previously this opened the file in the text editor which is very unlikely to be what user would want.
The-Compiler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file://foo is not a correct file URL, see https://en.wikipedia.org/wiki/File_URI_scheme - also, you'd probably want to print the absolute filename there, I don't think relative file URLs are a thing.
At that point, I'd probably print both though, to make it easier to copy-paste the filename...
Actually, |
|
Yep, the path is not relative by default which means that adding file:// prefix makes it valid. I tested and worked fine for me (final url has 3 slashes). |
BeyondEvil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Maybe @RibeiroAna want's to have a say as well?
|
Ah, sorry, my bad! Didn't see that the path was absolute. |
|
Any chance to see this merged and ideally included in a release? I kinda miss it. |
|
@RibeiroAna Thanks! |
By default terminals would open files in editors and URLs in browsers. By printing the generated html report using an URL (file://) we enable users to click the terminal to open it. Previously this opened the file in the text editor which is very unlikely to be what user would want.
By default terminals would open files in editors and URLs in browsers.
By printing the generated html report using an URL (file://) we enable
users to click the terminal to open it. Previously this opened the file
in the text editor which is very unlikely to be what user would want.