Consolidate tests #131
Merged
Consolidate tests #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note that with this change, when we see something like I forgot to check if GitHub allows customizing the names that appear in the GHA results list, but I'll probably look into that before merging this. |
coordt
approved these changes
Nov 10, 2025
We run a lot of tests in CI for such a small project, and in the past each tox environment has been run in a separate GitHub Actions job, but we don't really need to do that. The reason we've been splitting them up that way is to make it clear at a glance what configurations are failing when a CI run fails, but in practice we've never really had a failing workflow where we needed to look at all the different failing tox runs to understand the problem; looking at one failure is generally enough. So, in this commit, I'm consolidating the GHA jobs into one per Python version which will run all the tox environments for that Python version. This cuts down a bit on setup work, and might reduce the load on PyPI a bit, since downloaded packages can potentially be cached across different tox runs for the same Python version.
This commit enables persistence of the pip cache between different CI jobs, which will further reduce the load on PyPI.
diazona
force-pushed
the
consolidate-tests/1/dev
branch
from
854057c to
29b2195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run a lot of tests in CI for such a small project, and in the past each tox environment has been run in a separate GitHub Actions job, but we don't really need to do that. The reason we've been splitting them up that way is to make it clear at a glance what configurations are failing when a CI run fails, but in practice we've never really had a failing workflow where we needed to look at all the different failing tox runs to understand the problem; looking at one failure is generally enough.
So, in this PR, I'm consolidating the GHA jobs into one per Python version which will run all the tox environments for that Python version. I'm also enabling the persistent pip package cache. These changes cut down a bit on the amount of setup work done by GHA, and they should also reduce the load we place on PyPI.