New release of pytest-qt

[ghisvail]

Please consider uploading a new release with the recent fixes introduced for Python 3.6. The latter is due to become the default Python in Debian, so it is essential that the package builds and tests properly with this version onwards.

I'd also be interested in having both the docs and tests (#171) included in the source tarball uploaded on PyPI. PyPI is the preferred canonical location for Python source code on Debian.

Cheers,

[nicoddemus]

Will do, thanks for the ping!

[nicoddemus]

Hi @ghisvail,

I'd also be interested in having both the docs and tests (#171) included in the source tarball uploaded on PyPI.

I just checked an version 2.1.0 already contains tests and docs, thanks to setuptools_scm.

Noted about a new release with the 3.6 test fixes.

[ghisvail]

thanks to setuptools_scm

The downside of it is that you get a lot of useless files included in the release tarball, like project dotfiles or CI config files.

[nicoddemus]

Indeed but as a maintainer I find it worth the few extra kbytes in the source tarball of it means not having to deal with manifest files. 😉

[ghisvail]

Your manifest file should be 3 lines tops. It's not as if pytest-qt was such a big code base that maintaining a MANIFEST.in file was so demanding. I don't buy it, sorry.

[nicoddemus]

I don't buy it, sorry.

No problem. 👍

[ghisvail]

Importing the latest tarball introduced a huge diff compared to version 2.1.0. On further inspection, It looks like all line endings have changed from UNIX to Windows. This is not good. Please consider sticking to one format (UNIX preferably, since it is the one that was used until now).

[nicoddemus]

Ouch, definitely. Usually Travis publishes the packages, but because of #175 I had to make the release on my own box.

[ghisvail]

Could you fix that with a new upload?

[nicoddemus]

Only with a new release, one can't replace published tarballs on PyPI.

I just noticed that #168 should be merged, so I will see to it and make a 2.1.2 release.

[nicoddemus]

Just released 2.1.2 with the correct line endings. 👍