Use explicit try/finally to ensure loops quit when receiving a signal #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! |
nicoddemus
force-pushed
the
try-finally-quit
branch
from
5fd6e4f to
1f71905
Compare
nicoddemus
force-pushed
the
try-finally-quit
branch
from
1f71905 to
86e41e3
Compare
Member
Author
|
Also noticed that |
Member
|
I think in #71 (comment) we discovered it wasn't actually needed with |
Member
Author
|
Hmm oh yeah, we kinda just let it go at that. Oh well, I think now everything is working as it should. 😄 |
nicoddemus
added a commit
that referenced
this pull request
Dec 16, 2015
Use explicit try/finally to ensure loops quit when receiving a signal
nicoddemus
added a commit
that referenced
this pull request
Dec 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #114