-
-
Notifications
You must be signed in to change notification settings - Fork 70
Update documentation on pyqt4v2
#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/intro.rst
Outdated
| if both are set). | ||
|
|
||
| .. _version2: http://pyqt.sourceforge.net/Docs/PyQt4/incompatible_apis.html | ||
| Starting with ``pytest-qt`` version 2.0, ``PyQt`` or ``PySide`` are loaded after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this is too much information to be into the "introduction" part of the docs. Perhaps we can add an entry "A note about pyqt4v2", similar to A note about QApplication.exit() and add a link here?
|
Thanks for the follow up @montefra! |
|
@nicoddemus I've updated the info according to your suggestions. on a slightly related note: would you mind if I add |
Not at all, seems like a much better approach than the current one. 😁 |
|
can I do it here or would you prefer a new branch? |
|
Feel free to do it here, just make sure to use a separate commit. 👍 |
|
Excellent, many thanks @montefra! |
|
Glad to contribute back to a tool I use regularly. |
I have a tentative update of the documentation according to what we have discussed in #148.
I'm not very satisfied by it. I might change some of it in the next days. Comments are welcome