Fix compatibility with PyQt5 5.11.3 #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh definitely, brain fart on my part. 😝 Please feel free to merge and push the tag (to the commit in this PR, not to the merge commit) when AppVeyor finishes. 👍 |
nicoddemus
approved these changes
Oct 1, 2018
Member
Author
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of that assertion, we just break hard with PyQt5 5.11.3 (which is going to be released tomorrow or Wednesday) for any testsuite having pytest-qt installed.
IMHO, in the future we should prefer having a test which tests for the missing attribute instead of adding an assertion which breaks things for everyone 😉
I plan to push a tag directly after this is merged.