Skip to content

Conversation

sureshvv
Copy link

Found this bug while using the remote webdriver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be then we should .lower on both sides?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.15% when pulling cb0022a on sureshvv:feature-remote-webdriver-bug into fa4dc1e on pytest-dev:master.

@sureshvv
Copy link
Author

This is the smallest change that will work. splinter_webdriver is always lower case (firefox, chrome, remote etc.)

@bubenkoff
Copy link
Member

right

bubenkoff added a commit that referenced this pull request Apr 14, 2015
selenium remote webdriver is named Remote Webdriver
@bubenkoff bubenkoff merged commit cb4f566 into pytest-dev:master Apr 14, 2015
@sureshvv sureshvv deleted the feature-remote-webdriver-bug branch April 14, 2015 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants