requirement: pytest-asyncio >= 0.17

[Rikkuru]

@pytest_asyncio.fixture is absent in pytest-asyncio < 0.17

[andersglindstrom]

Hi @Rikkuru. What has to happen to get this merged to main? Do I need to do anything?

[Rikkuru]

Hi @Rikkuru. What has to happen to get this merged to main? Do I need to do anything?

I guess we need someone with write access to approve it

idk if this repo is even still maintained , can try tagging someone from pytest-dev

[nicoddemus]

I'm glad to approve/merge, however it would be nice if one of the maintainers to step up.

[andersglindstrom]

I'm the original author. I donated it to `pytest`. Does that make me a maintainer? I don't understand the governance.

…

On Sat, 21 Sept 2024 at 21:53, Bruno Oliveira ***@***.***> wrote: I'm glad to approve/merge, however it would be nice if one of the maintainers to step up. — Reply to this email directly, view it on GitHub <#77 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWINPKBN3O5H76CWOMPNO3ZXVM3VAVCNFSM6AAAAABN6XY4TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGE2TQOJTGI> . You are receiving this because you commented.Message ID: ***@***.***>

[nicoddemus]

I don't understand the governance.

We understand that the original maintainers will continue to maintain the package... to go under pytest-dev is just a mean to avoid bus factor... are you saying you do not want to maintain the package anymore? That is of course fine, just good to make that explicit.

[andersglindstrom]

Hi Bruno, I am very happy to maintain the package. When I initially saw the PR from Diana, which is the first one ever, I approved it but I couldn't find anyway to actually merge it to main. I wondered if I actually have permission to do so. I see now that it is not building. Maybe that's the reason there's no 'Merge' button? Kind regards, Anders.

…

On Mon, 23 Sept 2024 at 00:00, Bruno Oliveira ***@***.***> wrote: I don't understand the governance. We understand that the original maintainers will continue to maintain the package... to go under pytest-dev is just a mean to avoid bus factor... are you saying you do not want to maintain the package anymore? That is of course fine, just good to make that explicit. — Reply to this email directly, view it on GitHub <#77 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWINPJTYD7ZOMXHDZTXY5LZX3EPVAVCNFSM6AAAAABN6XY4TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWHAYDGMZTGI> . You are receiving this because you commented.Message ID: ***@***.***>

[nicoddemus]

Hi @andersglindstrom,

Oh I'm so sorry, it was always the intention to add you as maintainer of this project... somehow I must have missed a step when configuring the repository.

I've sent you an invitation:

With that you should be able to maintain the repository, as it was expected from the beginning... sorry again about that!

[andersglindstrom]

Hi Bruno, no worries :-) Anders.

…

On Wed, 25 Sept 2024 at 08:57, Bruno Oliveira ***@***.***> wrote: Hi @andersglindstrom <https://github.com/andersglindstrom>, Oh I'm so sorry, it was always the intention to add you as maintainer of this project... somehow I must have missed a step when configuring the repository. I've sent you an invitation: image.png (view on web) <https://github.com/user-attachments/assets/c6e3bde7-7bda-4f3d-9c1e-db00fb2d12bb> With that you should be able to maintain the repository, as it was expected from the beginning... sorry again about that! — Reply to this email directly, view it on GitHub <#77 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWINPPXTMMBDHI32QLHDOLZYHU6VAVCNFSM6AAAAABN6XY4TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSGUZDSOBVGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nicoddemus]

👍

Btw this is failing because newer tox versions are more strict and do not let external scripts execute by default:

py: commands[0]> build_scripts/run_tests.sh tests
py: failed with /home/runner/work/pytest-tcpclient/pytest-tcpclient/build_scripts/run_tests.sh (resolves to /home/runner/work/pytest-tcpclient/pytest-tcpclient/build_scripts/run_tests.sh) is not allowed, use allowlist_externals to allow it

[andersglindstrom]

I have discovered that the package doesn't work Python 3.12. The tests just hang. I went back to 3.8 and it's fine. I actually don't use the package at the moment. I'm open to suggestions about what to do with it.

…

On Wed, 25 Sept 2024 at 22:19, Bruno Oliveira ***@***.***> wrote: 👍 Btw this is failing because newer tox versions are more strict and do not let external scripts execute by default: py: commands[0]> build_scripts/run_tests.sh tests py: failed with /home/runner/work/pytest-tcpclient/pytest-tcpclient/build_scripts/run_tests.sh (resolves to /home/runner/work/pytest-tcpclient/pytest-tcpclient/build_scripts/run_tests.sh) is not allowed, use allowlist_externals to allow it — Reply to this email directly, view it on GitHub <#77 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWINPIT7Q6MOFCZC3BSNQDZYKS35AVCNFSM6AAAAABN6XY4TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTHEZDOMRSGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>