pytester: ignore files used to obtain current user metadata #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
fix-fdleaks
branch
from
709af12
to
6935e9d
Compare
nicoddemus
reviewed
Sep 16, 2017
_pytest/pytester.py
Outdated
| @@ -22,6 +22,11 @@ | |||
| from _pytest.assertion.rewrite import AssertionRewritingHook | |||
|
|
|||
|
|
|||
| IGNORE_PAM = [ # filenames added when obtaining details about the current user | |||
There was a problem hiding this comment.
thanks for noting, pam comes frim the plugablle authentification modules, the SSS module is the one that opens this file, constant however is indeed named bdly
changelog/2784.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| pytester: no ignore files used to obtain current user metadata in the fd leak detector | |||
There was a problem hiding this comment.
IIUC this should be "ignore files", not "no ignore files", right?
changelog/2784.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| pytester: no ignore files used to obtain current user metadata in the fd leak detector | |||
There was a problem hiding this comment.
Nit: please add a "." at the end of the sentence. 😉
|
@RonnyPfannschmidt gentle ping. |
|
will retry after #3016 |
RonnyPfannschmidt
force-pushed
the
fix-fdleaks
branch
from
6935e9d
to
2f05375
Compare
… fd leak detector
RonnyPfannschmidt
force-pushed
the
fix-fdleaks
branch
from
2f05375
to
ed293ec
Compare
RonnyPfannschmidt
changed the title
nicoddemus
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… fd leak detector