Skip to content

Deprecate --no-print-logs option #3238

Closed
@nicoddemus

Description

@nicoddemus

As commented in #3234 (comment) we want to deprecate --no-print-logs.


@Thisch to deprecate we basically should emit config.warn when the option is set, at first glance here seems like a good place:

self.print_logs = get_option_ini(config, 'log_print')

We should call config.warn if self.print_logs (after accounting for command-line and ini option) is False.

Then we should add a test to deprecated_test.py and I believe that's it. As usual feel free to ask if you have questions. 😁

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueeasy issue that is friendly to new contributorplugin: loggingrelated to the logging builtin plugintype: deprecationfeature that will be removed in the future

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions