New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't assert on xpassed and xfailed in runresult #3837

Closed
wimglenn opened this Issue Aug 20, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@wimglenn
Contributor

wimglenn commented Aug 20, 2018

Just need to be added here:

def assert_outcomes(self, passed=0, skipped=0, failed=0, error=0):

@RonnyPfannschmidt

This comment has been minimized.

Show comment
Hide comment
@RonnyPfannschmidt

RonnyPfannschmidt Aug 20, 2018

Member

i invite you to do that and add a test for it as well

Member

RonnyPfannschmidt commented Aug 20, 2018

i invite you to do that and add a test for it as well

@wimglenn

This comment has been minimized.

Show comment
Hide comment
@wimglenn

wimglenn Aug 20, 2018

Contributor

Done already Ronny, just needed to create the issue first to get the issue # for the filename in changelog

Contributor

wimglenn commented Aug 20, 2018

Done already Ronny, just needed to create the issue first to get the issue # for the filename in changelog

@RonnyPfannschmidt

This comment has been minimized.

Show comment
Hide comment
@RonnyPfannschmidt

RonnyPfannschmidt Aug 20, 2018

Member

oh great job then, note that you could have used the # of the pull request as well

Member

RonnyPfannschmidt commented Aug 20, 2018

oh great job then, note that you could have used the # of the pull request as well

@wimglenn

This comment has been minimized.

Show comment
Hide comment
@wimglenn

wimglenn Aug 20, 2018

Contributor

So no need to make the issue if you have a PR ready?

Contributor

wimglenn commented Aug 20, 2018

So no need to make the issue if you have a PR ready?

@RonnyPfannschmidt

This comment has been minimized.

Show comment
Hide comment
@RonnyPfannschmidt
Member

RonnyPfannschmidt commented Aug 20, 2018

correct

@wimglenn wimglenn closed this Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment