main: fix reversed collection order in Session #11957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're working with a stack (last in first out), we need to append to it in reverse to preserve the order when popped. Fix pytest-dev#11937.
bluetech
commented
Feb 9, 2024
| pytester.copy_example("issue88_initial_file_multinodes") | ||
| p = pytester.makepyfile("def test_hello(): pass") | ||
| result = pytester.runpytest(p, "--collect-only") | ||
| result.stdout.fnmatch_lines(["*Module*test_issue88*", "*MyFile*test_issue88*"]) |
There was a problem hiding this comment.
This existing test and the one below actually flagged the issue in #11646, but I misdiagnosed it and accepted the changes. So this brings the tests to how they were.
There was a problem hiding this comment.
Probably leave a comment making the intent of the test more explicit?
There was a problem hiding this comment.
This test failing was mostly incidental, it does not aim specifically to test ordering but something with custom nodes. I added the new test to check the order specifically which will be much harder to misdiagnose.
4 tasks
bluetech
added
the
needs backport
nicoddemus
approved these changes
Feb 12, 2024
| pytester.copy_example("issue88_initial_file_multinodes") | ||
| p = pytester.makepyfile("def test_hello(): pass") | ||
| result = pytester.runpytest(p, "--collect-only") | ||
| result.stdout.fnmatch_lines(["*Module*test_issue88*", "*MyFile*test_issue88*"]) |
There was a problem hiding this comment.
Probably leave a comment making the intent of the test more explicit?
RonnyPfannschmidt
approved these changes
Feb 12, 2024
bluetech
added
backport 8.0.x
and removed
needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're working with a stack (last in first out), we need to append to it in reverse to preserve the order when popped.
Fix #11937.