Skip to content

doc: fix grammar error i.e. -> e.g. #13586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

doc: fix grammar error i.e. -> e.g. #13586

merged 1 commit into from
Jul 5, 2025

Conversation

corneliusroemer
Copy link
Contributor

The list is probably not exhaustive hence e.g. should be used not I.e.

@corneliusroemer
doc: fix grammar error i.e. -> e.g.
a9f9d3c 
The list is probably not exhaustive hence e.g. should be used not I.e.
webknjaz
webknjaz approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably works both ways in this context.

@RonnyPfannschmidt RonnyPfannschmidt added the skip news used on prs to opt out of the changelog requirement label Jul 5, 2025
@nicoddemus nicoddemus merged commit 39ed26a into pytest-dev:main Jul 5, 2025
36 checks passed
@corneliusroemer
Copy link
Contributor Author

It probably works both ways in this context.

@webknjaz why do you think so? Is the list exhaustive?

Pierre-Sassoulas
Pierre-Sassoulas reviewed Jul 5, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure 'Ida est' (in other words...) require exhaustiveness to be correct, and I think this kind of changes is a rather poor use of reviewer's time. (and arguing about it is an even poorer use of maintainer time).

pull bot pushed a commit to mergify-ci-insights/pytest that referenced this pull request Jul 16, 2025
@corneliusroemer @pull
doc: fix grammar error i.e. -> e.g. (pytest-dev#13586)
375e6a7 
The list is probably not exhaustive hence e.g. should be used not I.e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
skip news used on prs to opt out of the changelog requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corneliusroemer @RonnyPfannschmidt @webknjaz @Pierre-Sassoulas @nicoddemus