fixtures: fix fixture closure calculation to properly consider overridden fixtures #13774
+142
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
bluetech
force-pushed
the
fixture-closure-overrides
branch
from
af00c4a to
70bc221
Compare
bluetech
commented
Oct 2, 2025
| result.assert_outcomes(passed=1) | ||
|
|
||
|
|
||
| @pytest.mark.xfail(reason="not currently handled correctly") |
There was a problem hiding this comment.
When working on this I thought of this more complicated situation, which unfortunately still fails. It needs the analysis to include visibility, which is more difficult. But this change is still an improvement.
bluetech
force-pushed
the
fixture-closure-overrides
branch
from
70bc221 to
72ae3db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13773.