Skip symlink sibling test on Windows without symlink support #13792
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Issue #12039 is already closed. Was the fix not sufficient? |
bluetech
added
the
status: needs information
mulatmek
force-pushed
the
fix-windows-symlink-test
branch
2 times, most recently
from
07c7fbb to
cbf4928
Compare
bluetech
removed
the
status: needs information
bluetech
requested changes
Oct 7, 2025
mulatmek
force-pushed
the
fix-windows-symlink-test
branch
2 times, most recently
from
b421d7f to
da454c7
Compare
bluetech
reviewed
Oct 7, 2025
mulatmek
force-pushed
the
fix-windows-symlink-test
branch
2 times, most recently
from
83f1a5e to
f37d514
Compare
bluetech
approved these changes
Oct 7, 2025
|
@bluetech Codecov failure is expected here since the diff only touches tests. |
bluetech
reviewed
Oct 7, 2025
auto-merge was automatically disabled
October 7, 2025 11:35
Head branch was pushed to by a user without write access
mulatmek
force-pushed
the
fix-windows-symlink-test
branch
from
f6019be to
f48ded3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Windows environments without Developer Mode or admin privileges,
symlink creation is not supported. This caused
test_do_not_collect_symlink_siblingsto fail even though pytestbehavior was correct.
This patch adds a skip condition to avoid false negatives.
Related issue
Closes #13771
Changelog
Added
changelog/12039.bugfix.rst:test_do_not_collect_symlink_siblingson Windows without symlink support.