Skip to content

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 18, 2019

TODO:

  • test

def __repr__(self):
return (
"<RunResult ret=%r len(stdout.lines)=%d len(stderr.lines)=%d duration=%.2fs>"
% (self.ret, len(self.stdout.lines), len(self.stderr.lines), self.duration)
Copy link
Contributor Author

@blueyed blueyed Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len appears to be 1 always (empty line(s)), but appears to be ok?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's fine. 👍

@nicoddemus nicoddemus changed the title Add __repr__ for RunResult WIP Add __repr__ for RunResult Jan 22, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Feb 8, 2019

Added a test.

@blueyed blueyed changed the title WIP Add __repr__ for RunResult Add __repr__ for RunResult Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #4652 into features will increase coverage by 0.16%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #4652      +/-   ##
============================================
+ Coverage     95.57%   95.73%   +0.16%     
============================================
  Files           113      111       -2     
  Lines         24991    24688     -303     
  Branches       2481     2448      -33     
============================================
- Hits          23884    23634     -250     
+ Misses          783      745      -38     
+ Partials        324      309      -15
Flag Coverage Δ
#docs 29.59% <50%> (+0.1%) ⬆️
#doctesting 29.59% <50%> (+0.1%) ⬆️
#linting 29.59% <50%> (+0.1%) ⬆️
#linux 95.56% <50%> (+0.12%) ⬆️
#nobyte 92.33% <50%> (+0.64%) ⬆️
#numpy 93.16% <50%> (+51.11%) ⬆️
#pexpect 42.08% <50%> (+0.04%) ⬆️
#py27 93.73% <50%> (+0.18%) ⬆️
#py34 91.83% <50%> (?)
#py35 91.85% <50%> (?)
#py36 91.87% <50%> (?)
#py37 93.89% <50%> (+0.37%) ⬆️
#trial 93.16% <50%> (+51.11%) ⬆️
#windows 93.9% <50%> (+2.49%) ⬆️
#xdist 93.76% <50%> (+0.06%) ⬆️
Impacted Files Coverage Δ
src/_pytest/pytester.py 87.33% <50%> (+0.33%) ⬆️
src/_pytest/warning_types.py 92.85% <0%> (-7.15%) ⬇️
src/_pytest/_code/source.py 90.74% <0%> (-0.85%) ⬇️
testing/python/raises.py 94.28% <0%> (-0.31%) ⬇️
src/_pytest/junitxml.py 94.36% <0%> (-0.21%) ⬇️
src/_pytest/skipping.py 95.23% <0%> (-0.17%) ⬇️
src/_pytest/monkeypatch.py 93.87% <0%> (-0.17%) ⬇️
src/_pytest/nose.py 97.22% <0%> (-0.08%) ⬇️
src/_pytest/reports.py 97.4% <0%> (-0.07%) ⬇️
testing/test_nose.py 98.86% <0%> (-0.05%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a131cd6...9bcbf55. Read the comment docs.

@blueyed blueyed merged commit ed01dc6 into pytest-dev:features Feb 9, 2019
@blueyed blueyed deleted the RunResult-repr branch February 9, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants