-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add __repr__ for RunResult #4652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
def __repr__(self): | ||
return ( | ||
"<RunResult ret=%r len(stdout.lines)=%d len(stderr.lines)=%d duration=%.2fs>" | ||
% (self.ret, len(self.stdout.lines), len(self.stderr.lines), self.duration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
len appears to be 1 always (empty line(s)), but appears to be ok?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's fine. 👍
2fbd56d
to
9bcbf55
Compare
Added a test. |
Codecov Report
@@ Coverage Diff @@
## features #4652 +/- ##
============================================
+ Coverage 95.57% 95.73% +0.16%
============================================
Files 113 111 -2
Lines 24991 24688 -303
Branches 2481 2448 -33
============================================
- Hits 23884 23634 -250
+ Misses 783 745 -38
+ Partials 324 309 -15
Continue to review full report at Codecov.
|
TODO: