Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain more_itertools for Python 2.7 compatibility #4774

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@sambrightman
Copy link

commented Feb 12, 2019

Fixes #4772, #4770.

There was some discussion in #4770 that maybe this can be written slightly differently but it worked for me like this.

I assume this doesn't require a changelog entry.

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Thanks a lot @sambrightman for providing this PR and testing that it works.

I assume this doesn't require a changelog entry.

Oh I believe it does, as definitely the Python 2 users which are facing this problem would like to know about it in the CHANGELOG. 👍

Sam Brightman
@sambrightman

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

Ok, changelog entry added.

@hugovk

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Fixes #4772, #4770.

GitHub tip: when this is merged, only the first issue will be autoclosed. Repeat the keyword to autoclose both:

Fixes #4772, fixes #4770.

Docs: https://help.github.com/articles/closing-issues-using-keywords/

@sambrightman

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

Thanks! In this case #4772 is already closed.

@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #4774 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4774      +/-   ##
==========================================
+ Coverage   95.67%   95.69%   +0.01%     
==========================================
  Files         113      113              
  Lines       25012    25012              
  Branches     2484     2484              
==========================================
+ Hits        23930    23935       +5     
+ Misses        764      762       -2     
+ Partials      318      315       -3
Flag Coverage Δ
#docs 29.66% <ø> (+0.1%) ⬆️
#doctesting 29.66% <ø> (+0.1%) ⬆️
#linting 29.66% <ø> (+0.1%) ⬆️
#linux 95.52% <ø> (+0.03%) ⬆️
#nobyte 92.3% <ø> (ø) ⬆️
#numpy 93.07% <ø> (+0.01%) ⬆️
#pexpect 42.04% <ø> (+0.02%) ⬆️
#pluggymaster 93.81% <ø> (+0.1%) ⬆️
#py27 93.71% <ø> (+0.03%) ⬆️
#py34 91.78% <ø> (+0.06%) ⬆️
#py35 91.78% <ø> (+0.06%) ⬆️
#py36 91.8% <ø> (+0.06%) ⬆️
#py37 93.81% <ø> (ø) ⬆️
#trial 93.07% <ø> (+0.01%) ⬆️
#windows 93.83% <ø> (-0.02%) ⬇️
#xdist 93.73% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.85% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dd10d...a800328. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #4774 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4774      +/-   ##
==========================================
+ Coverage   95.67%   95.69%   +0.01%     
==========================================
  Files         113      113              
  Lines       25012    25012              
  Branches     2484     2484              
==========================================
+ Hits        23930    23935       +5     
+ Misses        764      762       -2     
+ Partials      318      315       -3
Flag Coverage Δ
#docs 29.66% <ø> (+0.1%) ⬆️
#doctesting 29.66% <ø> (+0.1%) ⬆️
#linting 29.66% <ø> (+0.1%) ⬆️
#linux 95.52% <ø> (+0.03%) ⬆️
#nobyte 92.3% <ø> (ø) ⬆️
#numpy 93.07% <ø> (+0.01%) ⬆️
#pexpect 42.04% <ø> (+0.02%) ⬆️
#pluggymaster 93.81% <ø> (+0.1%) ⬆️
#py27 93.71% <ø> (+0.03%) ⬆️
#py34 91.78% <ø> (+0.06%) ⬆️
#py35 91.78% <ø> (+0.06%) ⬆️
#py36 91.8% <ø> (+0.06%) ⬆️
#py37 93.81% <ø> (ø) ⬆️
#trial 93.07% <ø> (+0.01%) ⬆️
#windows 93.83% <ø> (-0.02%) ⬇️
#xdist 93.73% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.85% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dd10d...a800328. Read the comment docs.

@nicoddemus nicoddemus merged commit 8052d01 into pytest-dev:master Feb 12, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 67dd10d...a800328
Details
codecov/project 95.69% (+0.01%) compared to 67dd10d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vreuter added a commit to databio/pypiper that referenced this pull request Feb 19, 2019

schandrika added a commit to schandrika/volttron that referenced this pull request Feb 22, 2019

schandrika added a commit to schandrika/volttron that referenced this pull request Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.