Skip to content

Conversation

asottile
Copy link
Member

Resolves #4716

@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #4804 into master will decrease coverage by 0.01%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
- Coverage   95.65%   95.64%   -0.02%     
==========================================
  Files         113      113              
  Lines       25057    25066       +9     
  Branches     2489     2493       +4     
==========================================
+ Hits        23968    23974       +6     
- Misses        768      770       +2     
- Partials      321      322       +1
Flag Coverage Δ
#docs 29.6% <0%> (-62.59%) ⬇️
#doctesting 29.6% <0%> (-62.59%) ⬇️
#linting 29.6% <0%> (-62.59%) ⬇️
#linux 95.46% <27.27%> (-0.02%) ⬇️
#nobyte 92.18% <27.27%> (-0.03%) ⬇️
#numpy 92.98% <27.27%> (-0.01%) ⬇️
#pexpect 42.05% <0%> (+0.01%) ⬆️
#pluggymaster 93.7% <27.27%> (+0.03%) ⬆️
#py27 93.65% <27.27%> (-0.01%) ⬇️
#py34 91.57% <27.27%> (-0.03%) ⬇️
#py35 91.56% <27.27%> (-0.03%) ⬇️
#py36 91.58% <27.27%> (-0.03%) ⬇️
#py37 93.77% <27.27%> (-0.01%) ⬇️
#trial 92.98% <27.27%> (-0.01%) ⬇️
#windows 93.67% <27.27%> (-0.83%) ⬇️
#xdist 93.68% <27.27%> (-0.03%) ⬇️
Impacted Files Coverage Δ
testing/test_skipping.py 97.65% <0%> (-1.03%) ⬇️
testing/code/test_source.py 95.53% <42.85%> (-1.01%) ⬇️
src/_pytest/terminal.py 91.85% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36e986...5505826. Read the comment docs.

@asottile
Copy link
Member Author

This is ready to go, despite the status list

@nicoddemus nicoddemus merged commit eeac28f into pytest-dev:master Feb 18, 2019
@asottile asottile deleted the fix_py38 branch February 18, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants