Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
--pdbcls: improve validation, and allow for "mod:attr.class" #4855
@@ Coverage Diff @@ ## features #4855 +/- ## ============================================ - Coverage 93.97% 92.03% -1.94% ============================================ Files 113 113 Lines 25211 25235 +24 Branches 2501 2502 +1 ============================================ - Hits 23693 23226 -467 - Misses 1139 1600 +461 - Partials 379 409 +30
Started looking at this, but stopped when I've found that codecov considers a "def" not being covered, although the function is: https://codecov.io/gh/pytest-dev/pytest/src/c4c979fce27442c4e4e92ded61f100aef0762119/testing/test_warnings.py#L699
The missing-def issue appears to affect more lines there.
In the base (current features) the def-lines are covered from 2 builds only, while others are from 44 (there are so many due to #4856).
Mar 1, 2019
Hmm sorry, I didn't get that. You said:
I then "Approved" and would immediately merge it, but I got called off my desk for a few minutes, that's why I did merge a few minutes later only.
Feel free to leave a comment making that explicit; usually we can merge right after a single approve.