Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: move terminal summary code to terminal plugin #5069

Merged
merged 5 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 7, 2019

Fixes #5067.

TODO:

  • changelog
@codecov

This comment has been minimized.

Copy link

commented Apr 7, 2019

Codecov Report

Merging #5069 into features will decrease coverage by 4.79%.
The diff coverage is 96.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           features    #5069     +/-   ##
===========================================
- Coverage     96.07%   91.28%   -4.8%     
===========================================
  Files           114      115      +1     
  Lines         25823    25880     +57     
  Branches       2554     2421    -133     
===========================================
- Hits          24810    23625   -1185     
- Misses          704     1842   +1138     
- Partials        309      413    +104
Impacted Files Coverage Δ
testing/test_skipping.py 97.47% <ø> (-0.18%) ⬇️
src/_pytest/skipping.py 92.23% <ø> (-3.33%) ⬇️
testing/test_terminal.py 97.94% <100%> (-1.88%) ⬇️
src/_pytest/terminal.py 90.01% <95.58%> (-2.45%) ⬇️
testing/test_pdb.py 40% <0%> (-59.21%) ⬇️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 33.33% <0%> (-41.67%) ⬇️
testing/python/approx.py 80.45% <0%> (-19.18%) ⬇️
src/_pytest/compat.py 77.88% <0%> (-19.1%) ⬇️
src/_pytest/debugging.py 70.37% <0%> (-18.52%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b549438...dde27a2. Read the comment docs.

@blueyed blueyed force-pushed the blueyed:cleanup-summary-to-terminal branch from b8fe24f to d8d835c Apr 7, 2019

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Looks OK so far. What do you think still needs improvement, besides a CHANGELOG?

keywords = getattr(event, "keywords", {})
# folding reports with global pytestmark variable
# this is workaround, because for now we cannot identify the scope of a skip marker
# TODO: revisit after marks scope would be fixed

This comment has been minimized.

Copy link
@nicoddemus

nicoddemus Apr 9, 2019

Member

@RonnyPfannschmidt is now the time to revisit this?

@blueyed

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

I don't think it needs a changelog - it is only internal cleanup.

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

I don't think it needs a changelog - it is only internal cleanup.

I understand, but I think it still worth adding one, I can imagine someone accessing the moved functions in a custom plugin or something like that.

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

(A trivial changelog entry that is)

@blueyed blueyed requested a review from nicoddemus Apr 10, 2019

@@ -0,0 +1 @@
The code for the short test summary in the terminal was moved to the terminal plugin.

This comment has been minimized.

Copy link
@nicoddemus

nicoddemus Apr 10, 2019

Member

Thanks 🙇

This comment has been minimized.

Copy link
@blueyed

blueyed Apr 10, 2019

Author Contributor

You're welcome - sounds really trivial after all indeed.. ;)

/me needs to appreciate changelogs more / not getting annoyed by having to add them.. at least [ci skip] allows to skip Travis.

@nicoddemus nicoddemus merged commit f5d2b19 into pytest-dev:features Apr 10, 2019

4 checks passed

WIP Ready for review
Details
codecov/patch 96.84% of diff hit (target 96.07%)
Details
codecov/project Absolute coverage decreased by -4.79% but relative coverage increased by +0.76% compared to b549438
Details
pytest-CI #20190410.3 succeeded
Details

@blueyed blueyed deleted the blueyed:cleanup-summary-to-terminal branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.