Skip to content

pytester: runpytest_inprocess: use splitlines() #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

pytester: runpytest_inprocess: use splitlines() #6041

merged 1 commit into from
Oct 23, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 22, 2019

This avoids having a trailing empty lines always.

@blueyed blueyed force-pushed the pytester-splitlines branch from 2a58033 to 09a014f Compare October 23, 2019 01:19
@blueyed
pytester: runpytest_inprocess: use splitlines()
2f589a9 
This avoids having a trailing empty lines always.
@blueyed blueyed force-pushed the pytester-splitlines branch from 09a014f to 2f589a9 Compare October 23, 2019 02:34
asottile
asottile approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I like this

@blueyed blueyed merged commit 6242777 into pytest-dev:features Oct 23, 2019
@blueyed blueyed deleted the pytester-splitlines branch October 23, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @asottile