Skip to content

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 2, 2019

Via blueyed#42.

@blueyed blueyed merged commit 9071a2a into pytest-dev:features Nov 6, 2019
@blueyed blueyed deleted the FSCollector-fspath branch November 6, 2019 12:10
def __init__(self, fspath, parent=None, config=None, session=None, nodeid=None):
fspath = py.path.local(fspath) # xxx only for test_resultlog.py?
def __init__(
self, fspath: py.path.local, parent=None, config=None, session=None, nodeid=None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bluetech
Here the fspath: py.path.local slipped in - JFI (via #6129 - where I've removed it somewhere else after your review).
However, it might be good for documentation, and/or if we should ever add typing info for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants