tests: revisit test_cacheprovider #6199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting PYTHONDONTWRITEBYTECODE in the environment does not change it for the current process.
blueyed
changed the title
blueyed
force-pushed
the
tests-dont_write_bytecode
branch
from
3a3a9e5 to
d7dbbaf
Compare
2 tasks
bluetech
approved these changes
Nov 16, 2019
testing/test_cacheprovider.py
Outdated
| """ | ||
| ) | ||
| ) | ||
| testdir.makepyfile(**{"test_a.py": "def test_always_passes(): pass"}) |
There was a problem hiding this comment.
Is the .py in test_a.py still needed with makepyfile (rather than makefile)?
There was a problem hiding this comment.
No, and can also use kwargs directly. Amended.
testing/test_cacheprovider.py
Outdated
| test_b="""\ | ||
| def test_b1(): | ||
| assert 0 | ||
| **{ |
There was a problem hiding this comment.
Here can use regular kwargs I suppose?
blueyed
force-pushed
the
tests-dont_write_bytecode
branch
from
d7dbbaf to
4848a5a
Compare
blueyed
force-pushed
the
tests-dont_write_bytecode
branch
from
4848a5a to
b9a3ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the current process.