tox: add mypy toxenv #6446
tox: add mypy toxenv #6446
Conversation
Does pre-commit add its own configurations?
This will be nice to have, IIUC, this currently only includes the non-testing dependencies. But the mypy run also includes |
.pre-commit-config.yaml
Outdated
| args: [--py3-plus] | ||
| - repo: https://github.com/pre-commit/mirrors-mypy | ||
| rev: v0.740 | ||
| rev: v0.740 # NOTE: keep this in sync with setup.py. |
There was a problem hiding this comment.
Just for anyone doing the merge from features, note that features is already at v0.761.
setup.py
Outdated
| ] | ||
| ], | ||
| "mypy": [ | ||
| "mypy==v0.740", # keep this in sync with .pre-commit-config.yaml. |
There was a problem hiding this comment.
What's the advantage of adding an extra over specifying a deps in [testenv:mypy] tox?
There was a problem hiding this comment.
If e.g. pre-commit could also use the extra, the version could be changed just there.
Given requirements.txt, tox.ini etc I often find it more sane to have this in a more central place like setup.py.
There was a problem hiding this comment.
OK, makes sense.
I fear though that people will see it and start doing pytest[mypy] due to a misconception. There are probably tools which parse the extras and show them to the user. So WDYT about changing the name to mypy-internal or _mypy or something like that?
There was a problem hiding this comment.
Good point. What about checkqa-mypy?
I thought it would have additional args, but does not have them. So the only diff is with the deps. Added the testing extra also. |
This is different from what pre-commit (in "linting") runs in that it uses stubs from (test) dependencies. It would make sense to run this on CI additionally (since there is no "pre-commit --skip mypy", and a separate config is not worth it). But currently it triggers a false positive though anyway (more-itertools/more-itertools#374).
2 participants
This is different from what pre-commit (in "linting") runs in that it
uses our config (alone), and stubs from dependencies.
It would make sense to run this on CI additionally (since there is no
"pre-commit --skip mypy", and a separate config is not worth it).
Currently it triggers a false positive though anyway
(more-itertools/more-itertools#374).