typing: fix _TracebackStyle

[blueyed]

Ref: blueyed#163

TODO:

• rebase to fix commit message
• check my stashes

[blueyed]

"native" in not used internally with FormattedExcinfo at least (https://github.com/blueyed/pytest/blob/f1609d6e956bdf4d712610d8e6ca9fbb0b2ed108/src/_pytest/_code/code.py#L612-L631), so it might make sense to have two different types here (but it makes sense to match the --tb option here I guess (currently (with this patch) missing "auto")) - but that would be a followup.

[bluetech]

Should line be added to ExceptionInfo.getrepr() docstring?

[blueyed]

I do not think it is used there - i.e. I am not sure.
I think it is only used here:

pytest/src/_pytest/terminal.py

Line 868 in 719e0e3

if self.config.option.tbstyle == "line":

[bluetech]

This looks good to me, but looking at the type of _repr_failure_py, I wonder:

1. Why do _repr_failure_py and repr_failure both exist? repr_failure just forwards directly _repr_failure_py so why not just inline it?
2. Is it correct that it can only take Failed and FixtureLookupError and not other exception types?
3. Is it possible to add overloads to it so this assert is not needed?
4. Should its style argument be typed with _TracebackStyle?

[blueyed]

1. it is used by other subclasses etc - it is rather tangled (I have some WIP to fix this, also for 4.)
2. IIRC we/I've limited this intentionally for what has been observed, but from the code it is clear that this is not correct:

   pytest/src/_pytest/nodes.py

   Lines 288 to 292 in 719e0e3

   	if isinstance(excinfo.value, Failed):
   	if not excinfo.value.pytrace:
   	return str(excinfo.value)
   	if isinstance(excinfo.value, FixtureLookupError):
   	return excinfo.value.formatrepr()

3. overload might be a good idea, but in general it would be better to not return a string there. Also it is based on excinfo.value.pytrace - so would need separate types for this I assume.
4. yes, I have that in the WIP to clean up handling of --fulltrace

[bluetech]

Should line be added to ExceptionInfo.getrepr() docstring?