Skip to content

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 3, 2020

This is a bad anti-pattern from what I can tell.

The only benefit here would be that the link for "nose" could be managed centrally, but there is certainly not really a need for it as it stands now.

This is a bad anti-pattern from what I can tell.
@blueyed blueyed added type: docs documentation improvement, missing or needing clarification type: enhancement new feature or API change, should be merged into features branch labels Mar 3, 2020
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

(I assume you'll want to merge this yourself? Happy to leave to you or proactively merge in future if you prefer)

@blueyed
Copy link
Contributor Author

blueyed commented Mar 6, 2020

(I assume you'll want to merge this yourself?)

Yes, thanks for the review! :)

@blueyed blueyed merged commit 9e8540f into pytest-dev:master Mar 6, 2020
@blueyed blueyed deleted the docs-rm-links-inc-upstream branch March 6, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: docs documentation improvement, missing or needing clarification type: enhancement new feature or API change, should be merged into features branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants