Add example for __test__ #7733
Merged
Add example for __test__ #7733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initially, I'd added my name to AUTHORS based on the PR prompt, but after reading the CONTRIBUTING guidelines in more detail, decided it wasn't warranted. I also cut the documentation down to 80 chars per line. For my development, is there something like |
nicoddemus
requested changes
Sep 9, 2020
doc/en/example/pythoncollection.rst
Outdated
| .. code-block:: python | ||
| # Will be discovered as a test | ||
| def test_class: |
There was a problem hiding this comment.
Suggested change
| def test_class: | |
| class TestClass: |
doc/en/example/pythoncollection.rst
Outdated
| collect_ignore_glob = ["*_py2.py"] | ||
| User modules with names matching ``test*.py`` may be discovered as tests. Since | ||
| Pytest 2.6, users can prevent this test discovery by setting a boolean |
There was a problem hiding this comment.
Suggested change
| Pytest 2.6, users can prevent this test discovery by setting a boolean | |
| Pytest 2.6, users can prevent pytest from discovering classes that start with ``Test`` by setting a boolean ``__test__`` attribute to ``False``. |
Also I think we only need the example with False set; otherwise the example using __test__ = True implies that pytest will discover the class for tests even if it doesn't match the python_classes configuration option, which is not true.
|
Thanks @nicoddemus ! Changes made. |
|
Thanks @JosephTLucas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR reference: https://twitter.com/pytestdotorg/status/1302444196842725376?s=20
This example page seemed to be the best location. Anywhere else you recommend?