-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add regendoc runs for fixture docs #8312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regendoc runs for fixture docs #8312
Conversation
This will be used to power regendoc runs for later tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @matthewhughes934!
I've run regendoc locally to ensure the added tests pass, but the resulting diff was rather large (and included some bad whitespace) so I've left it out. What might be best here? I was thinking of just commiting the results of the added tests.
I'm surprise there were many changes... did you run on Linux using Python 3.8?
Ah, I was running on 3.9. Diff is reasonable after a run on 3.8: 10dd3db |
Awesome, thanks a lot! Normally we squash the commits before merging, but I noticed you have some commits with |
Also update these tests ensure they pass, and be explicit about the test file called in an existing test to avoid unintentional calls to the added tests
This is the result of running: $ cd doc/en && make regen REGENDOC_FILES=fixture.rst
10dd3db
to
709c211
Compare
👍 rebased |
Fix various typos in fixture docs
Add basic emaillib for tests in fixture.rst
This will be used to power regendoc runs for later tests
Add regendoc runs for emaillib tests in fixture
Also update these tests ensure they pass.
This addresses Use regendoc in fixture.rst #8213
I've run
regendoc
locally to ensure the added tests pass, but the resulting diff was rather large (and included some bad whitespace) so I've left it out. What might be best here? I was thinking of just commiting the results of the added tests.