chore(developer-hub): dual image mode enable and use in OIS #3055
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
| darkSrc="/images/ois/OIS_Rewards_Example_Dark_1.png" | ||
| lightSrc="/images/ois/OIS_Rewards_Example_Light_1.png" | ||
| alt="Example 1 - Only Publisher Stake" |
There was a problem hiding this comment.
As per the fuma docs, referencing Images with URL
| .lightImage { | ||
| display: block; | ||
|
|
There was a problem hiding this comment.
created this module, and added them in a folder to follow the same pattern.
nidhi-singh02
changed the title
|  | ||
| <br /> | ||
| <DualModeImage | ||
| darkSrc="/images/ois/OIS_Rewards_Example_Dark_1.png" |
There was a problem hiding this comment.
It would be better to import the images and pass the import here. Next can do some automatic image optimization when you import images which it cannot do when you use image urls. Also you can colocate the images with where they're used which is nice
There was a problem hiding this comment.
I see, I was using image URL as per the fuma docs https://fumadocs.dev/docs/headless/custom-source#images
If there would be optimization by using the import, lets do it.
Summary
Rationale
How has this been tested?