chore(developer-hub): dual image mode enable and use in OIS #3055
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| .lightImage { | ||
| display: block; | ||
|
|
||
|
Comment on lines
+1
to
+3
There was a problem hiding this comment. created this module, and added them in a folder to follow the same pattern. |
||
| :global(.dark) & { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| .darkImage { | ||
| display: none; | ||
|
|
||
| :global(.dark) & { | ||
| display: block; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import clsx from "clsx"; | ||
| import { ImageZoom } from "fumadocs-ui/components/image-zoom"; | ||
| import Image from "next/image"; | ||
| import type { ComponentProps } from "react"; | ||
|
|
||
| import styles from "./index.module.scss"; | ||
|
|
||
| type ImageProps = ComponentProps<typeof Image>; | ||
| type Props = Omit<ImageProps, "src"> & { | ||
| darkSrc: string; | ||
| lightSrc: string; | ||
| }; | ||
|
|
||
| const DualModeImage = ({ | ||
| darkSrc, | ||
| lightSrc, | ||
| className, | ||
| alt, | ||
| width = 800, | ||
| height = 600, | ||
| sizes = "100vw", | ||
| ...props | ||
| }: Props) => { | ||
| const commonProps = { | ||
| alt, | ||
| width, | ||
| height, | ||
| sizes, | ||
| ...props, | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <ImageZoom | ||
| src={lightSrc} | ||
| className={clsx(styles.lightImage, className)} | ||
| {...commonProps} | ||
| /> | ||
| <ImageZoom | ||
| src={darkSrc} | ||
| className={clsx(styles.darkImage, className)} | ||
| {...commonProps} | ||
| /> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default DualModeImage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to import the images and pass the import here. Next can do some automatic image optimization when you import images which it cannot do when you use image urls. Also you can colocate the images with where they're used which is nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I was using image URL as per the fuma docs https://fumadocs.dev/docs/headless/custom-source#images
If there would be optimization by using the import, lets do it.