fix(hip-3-pusher): Multisig update support (only 1/N, no KMS) #3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tejasbadadare
approved these changes
Oct 23, 2025
Comment on lines
+50
to
+52
| if config.multisig.enable_multisig: | ||
| if not config.multisig.multisig_address: | ||
| raise Exception("Multisig enabled but missing multisig address") |
There was a problem hiding this comment.
You can enforce this directly in the pydantic model. Doing as much validation as possible in the model itself aligns with pydantic's philosophy of "if i can construct the object, i know it's valid."
class MultisigConfig(BaseModel):
enable_multisig: bool
multisig_address: Optional[str] = None
@model_validator(mode="after")
def validate_address_exists_if_multisig_enabled(self) -> 'MultisigConfig':
if self.enable_multisig and self.multisig_address is None:
raise ValueError("`multisig_address` must be provided when `enable_multisig` is True")
return self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support multisig oracle update as per https://hyperliquid.gitbook.io/hyperliquid-docs/hypercore/multi-sig .
Rationale
This allows us to provide our own wallet for updating without ever having access to the deployer oracle account. They can grant and revoke access at will.
How has this been tested?