fix(pyth-lazer-agent): Only send one success response per batch update #3186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Riateche
previously requested changes
Nov 13, 2025
| }, | ||
| ) | ||
| .await?; | ||
| anyhow::bail!("Error processing batch update: {:?}", err); |
Contributor
There was a problem hiding this comment.
I think this bail! may not be needed here. It's not present in handle_push_update. Looks like it will result in client receiving two error responses.
Comment on lines
259
to
272
| if let Err(err) = lazer_publisher | ||
| .push_feed_update(request_params.clone().into()) | ||
| .await | ||
| { | ||
| debug!("error while sending updates: {:?}", err); | ||
| send_json( | ||
| sender, | ||
| &JrpcErrorResponse { | ||
| jsonrpc: JsonRpcVersion::V2, | ||
| error: JrpcError::SendUpdateError(request_params.clone()).into(), | ||
| id: request_id.clone(), | ||
| }, | ||
| ) | ||
| .await?; |
Contributor
There was a problem hiding this comment.
This whole body of the for loop can be moved out into a function to avoid code duplication with handle_push_update.
Contributor
Author
There was a problem hiding this comment.
Sure, just need to come up with a distinction between "this update failed to send" and "sending the error response itself failed" which has a distinction here. Errors upon errors.
| batch_request: &[FeedUpdateParams], | ||
| request_id: JrpcId, | ||
| ) -> anyhow::Result<()> { | ||
| for request_params in batch_request.iter() { |
Contributor
There was a problem hiding this comment.
Suggested change
| for request_params in batch_request.iter() { | |
| for request_params in batch_request { |
keyvankhademi
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The jrpc handler is a bit tricky in terms of result chaining and sending responses. This is I think a sane refactor to handle batch updates in those cases where the publisher wants a response.
Rationale
MIAX testing feedback.
How has this been tested?