refactor(lazer): add exponent to AggregatedPriceFeedData #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danimhr
reviewed
Nov 13, 2025
| // [required] Exponent applied to all price and rate values for this feed. | ||
| // Actual value is `mantissa * 10 ^ exponent`. | ||
| // Restricted to int16. | ||
| optional int32 exponent = 9; |
Contributor
There was a problem hiding this comment.
Is it backward compatible?
Contributor
There was a problem hiding this comment.
I think we need to release this in 2 stages for backward compatibility.
first write this data to state, and then read it from state.
right @Riateche ?
Contributor
Author
There was a problem hiding this comment.
Adding a field is backwards compatible.
No, 2 stages are not needed. I made it so that if there is no value in the snapshot, it will fill exponent from static data.
danimhr
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add exponent field.
Rationale
It simplifies the code in a lot of places where we previously had to pass the exponent in a separate argument.
How has this been tested?