-
Notifications
You must be signed in to change notification settings - Fork 72
separate dev requirements from package extra #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok. Valid point. A question, though. When installing with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
===========================================
+ Coverage 99.40% 100.00% +0.59%
===========================================
Files 5 5
Lines 508 508
Branches 88 88
===========================================
+ Hits 505 508 +3
+ Misses 2 0 -2
+ Partials 1 0 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Not really, but even before none of the test requirements were part of |
|
No, you're not getting me. When calling |
correct
no |
I may suggest simplifying the package dependencies as it does not need to have all development and testing packages append to this package which can be also by some tools and needed so they may flag this package for too wide many requirements...
cc: @shaypal5