Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Feb 1, 2024

I may suggest simplifying the package dependencies as it does not need to have all development and testing packages append to this package which can be also by some tools and needed so they may flag this package for too wide many requirements...

cc: @shaypal5

@shaypal5
Copy link
Member

shaypal5 commented Feb 1, 2024

Ok. Valid point.

A question, though. When installing with python -m pip install -e . -r tests/requirements.txt, are all -r dependencies added to those coming from the install_requires in setup.py?

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28c8d0d) 99.40% compared to head (7a6ad24) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #141      +/-   ##
===========================================
+ Coverage   99.40%   100.00%   +0.59%     
===========================================
  Files           5         5              
  Lines         508       508              
  Branches       88        88              
===========================================
+ Hits          505       508       +3     
+ Misses          2         0       -2     
+ Partials        1         0       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c8d0d...7a6ad24. Read the comment docs.

@Borda
Copy link
Contributor Author

Borda commented Feb 1, 2024

A question, though. When installing with python -m pip install -e. -r tests/requirements.txt, are all -r dependencies added to those coming from the install_requires in setup.py?

Not really, but even before none of the test requirements were part of install_requires

@shaypal5
Copy link
Member

shaypal5 commented Feb 1, 2024

No, you're not getting me.

When calling python -m pip install -e. -r tests/requirements.txt, does pip install, as dependencies:
A. Everything defined in setup.py.install_requires AND everything defined in requirements.txt
B. Just dependencies defined in requirements.txt
?

@Borda
Copy link
Contributor Author

Borda commented Feb 1, 2024

When calling python -m pip install -e. -r tests/requirements.txt, does pip install, as dependencies:
A. Everything defined in setup.py.install_requires AND everything defined in requirements.txt

correct

B. Just dependencies defined in requirements.txt

no

@shaypal5 shaypal5 merged commit e5f2e83 into python-cachier:master Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants