Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Feb 12, 2024

this shall help standardize the docstrings, just a suggestion, and happy to talk about it 🐰

@codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b510582) 99.41% compared to head (43fe18a) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #162      +/-   ##
===========================================
+ Coverage   99.41%   100.00%   +0.58%     
===========================================
  Files           5         5              
  Lines         513       513              
  Branches       87        87              
===========================================
+ Hits          510       513       +3     
+ Misses          2         0       -2     
+ Partials        1         0       -1     
Files Coverage Δ
cachier/base_core.py 100.00% <ø> (ø)
cachier/core.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b510582...43fe18a. Read the comment docs.

@Borda Borda changed the title precoomit: introduce docformatter precommit: introduce docformatter Feb 12, 2024
Copy link
Member

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, no need for a discussion here. I like neat docstrings.

@shaypal5 shaypal5 merged commit f035c3a into master Feb 13, 2024
@shaypal5 shaypal5 deleted the precommit/docformatter branch February 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants