Skip to content

fix: handling default kw arguments #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 13, 2024
Merged

fix: handling default kw arguments #172

merged 8 commits into from
Feb 13, 2024

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Feb 13, 2024

Adding test which shows that default kwargs were ignored in hash creation so again, passing identical arguments yielded in computing twice

@Borda Borda added the bug label Feb 13, 2024
@Borda Borda requested a review from shaypal5 as a code owner February 13, 2024 19:34
shaypal5
shaypal5 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you!

@shaypal5 shaypal5 merged commit c16f0f1 into master Feb 13, 2024
@shaypal5 shaypal5 deleted the fix/defaults branch February 13, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaypal5 shaypal5 shaypal5 approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Borda @shaypal5