Add a reference to the correct environment to pypi releaseflow #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaypal5
temporarily deployed
to
pypi_publish
GitHub Actions
Inactive
Member
Author
|
Awaiting your approval, @Borda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'd love your help, @Borda .
I've set up a new dedicated Github Actions environment for this repository, named
pypi_publish, which has aPYPI_PASSWORDsecret withcachier's PyPI API token.However, from what I understand, a Github Actions environment is a job-level property:
https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#using-an-environment
This seems a bit risky to me; a possible attack on PyPI secrets is now not only doing something fishy in the
gh-action-pypi-publish@v1.8.11action, but also in any unrelated action we use earlier in the flow (in this case,AButler/upload-release-assets@v3.0).So my question is, can you figure out a way to separate the PyPI upload step into a separate job in the same flow? Alternatively, is there a way to set up the environment for only a single step?
Cheers!