Skip to content

Conversation

@shaypal5
Copy link
Member

Also, a question, @Borda:
Why are we using prettier if it does not support Python?
https://prettier.io/docs/en/
Not even through plugins:
https://prettier.io/docs/en/plugins

@shaypal5 shaypal5 requested a review from Borda February 15, 2024 12:29
@shaypal5 shaypal5 marked this pull request as ready for review February 15, 2024 12:29
@codecov
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a480ed) 97.85% compared to head (8d86a51) 97.85%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files           6        6           
  Lines         514      514           
  Branches       96       96           
=======================================
  Hits          503      503           
  Misses         10       10           
  Partials        1        1           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a480ed...8d86a51. Read the comment docs.

@Borda
Copy link
Contributor

Borda commented Feb 15, 2024

Why are we using prettier if it does not support Python?

it is for GH action formatting which are YAML files

@shaypal5 shaypal5 merged commit 21680ff into master Feb 15, 2024
@shaypal5 shaypal5 deleted the adjust-line-length-for-prettier branch February 15, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants