Skip to content

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Feb 19, 2024

resolves #146

@shaypal5
Copy link
Member

Tell me if you need me to set up any secrets or environment variables in out GitHub Actions environments.

@Borda
Copy link
Contributor Author

Borda commented Feb 20, 2024

Tell me if you need me to set up any secrets or environment variables in out GitHub Actions environments.

It shall not be needed; otherwise, it won't be changed, right?
seems we would need to run MongoDB with docker so it can run on all OS so far the two actions I tried were limited to Linux only :/

@shaypal5
Copy link
Member

Tell me if you need me to set up any secrets or environment variables in out GitHub Actions environments.

It shall not be needed; otherwise, it won't be changed, right? seems we would need to run MongoDB with docker so it can run on all OS so far the two actions I tried were limited to Linux only :/

Right you are! Silly me...

Well, let see if you can work the kinks out...

@Borda Borda marked this pull request as ready for review February 20, 2024 19:45
@Borda Borda requested a review from shaypal5 as a code owner February 20, 2024 19:45
@Borda
Copy link
Contributor Author

Borda commented Feb 24, 2024

@shaypal5 figured out the docker on Mac o it is a full matrix 🦩

@shaypal5
Copy link
Member

@Borda
This cannot be rebased automatically from within GitHub, due to conflicts.
Please rebase manually and I'll squash and merge it.

@Borda Borda merged commit 90488c9 into master Feb 26, 2024
@Borda Borda deleted the ci/db branch February 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduce number of events on a PR

3 participants