Skip to content

fix: redefine partial kwargs #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: redefine partial kwargs #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cachier/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _convert_args_kwargs(
# unwrap if the function is functools.partial
if hasattr(func, "func"):
args = func.args + args
kwds = dict(**func.keywords, **kwds)
kwds.update({k: v for k, v in func.keywords.items() if k not in kwds})
func = func.func
func_params = list(inspect.signature(func).parameters)
args_as_kw = dict(
Expand Down
6 changes: 6 additions & 0 deletions tests/test_general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,18 @@ def fn_minus(a, b=2):
dummy_ = functools.partial(fn, 1)
assert cachier_(dummy_)() == expected

dummy_ = functools.partial(fn, 1)
assert cachier_(dummy_)(2) == expected

dummy_ = functools.partial(fn, a=1)
assert cachier_(dummy_)() == expected

dummy_ = functools.partial(fn, b=2)
assert cachier_(dummy_)(1) == expected

dummy_ = functools.partial(fn, b=2)
assert cachier_(dummy_)(1, b=2) == expected

assert cachier_(fn)(1, 2) == expected
assert cachier_(fn)(a=1, b=2) == expected

Expand Down