Skip to content

Conversation

@kmvanbrunt
Copy link
Member

@kmvanbrunt kmvanbrunt commented Nov 20, 2019

Added capability to override the argument parser class used by cmd2 built-in commands
Closes #770

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #812 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   97.25%   97.26%   +<.01%     
==========================================
  Files          14       14              
  Lines        3503     3506       +3     
==========================================
+ Hits         3407     3410       +3     
  Misses         96       96
Impacted Files Coverage Δ
cmd2/cmd2.py 96.54% <100%> (ø) ⬆️
cmd2/argparse_custom.py 94.23% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c00d34...0d6e9cb. Read the comment docs.

@kmvanbrunt
Copy link
Member Author

Does anyone think cmd2_parser_module should be renamed to cmd2_parser_module_name since it needs to be a string?

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding an example and unit test

@tleonhardt tleonhardt merged commit 1cad8d9 into master Nov 23, 2019
@tleonhardt tleonhardt deleted the custom_parser branch November 23, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow customization of the default argument parser used by cmd2

3 participants