Improved CommandSet instance resolution during argparse argument completion, fixes #967 #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 97.78% 97.79% +0.01%
==========================================
Files 22 22
Lines 4465 4493 +28
==========================================
+ Hits 4366 4394 +28
Misses 99 99
Continue to review full report at Codecov.
|
kmvanbrunt
previously approved these changes
Aug 6, 2020
Member
kmvanbrunt
left a comment
kmvanbrunt
left a comment
There was a problem hiding this comment.
We'll want to improve code coverage get_defining_class()
passing it a CommandSet instance. Search for a CommandSet instance that matches the completer's parent class type.` Resolves Issue #967 Renamed isolated_tests directory to tests_isolated for better visual grouping. Added some exception documentation
anselor
force-pushed
the
cmdset_completers
branch
from
804a424 to
e2d71ec
Compare
kmvanbrunt
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that a completer function is defined in a CommandSet before
passing it a CommandSet instance.
Search for a CommandSet instance that matches the completer's parent
class type.`
Resolves Issue #967
Renamed isolated_tests directory to tests_isolated for better visual grouping. Added some exception documentation