-
-
Notifications
You must be signed in to change notification settings - Fork 9
Use New Static Build Site API #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the build the script to use the new API provided by the site to fetch and download artifacts. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This is failing because the multiversion build takes more than 3 minutes currently. There are a few options:
|
|
cc @ChrisLovering if you have any thoughts |
|
I like the idea of not building multi-version for PRs. Having long CI in PRs is annoying anyway, so only building the new stuff sounds good. |
|
Maybe we could even go as far as storing/caching the "old" versions of sphinx-mutliversion, and pulling form that, rather than building each time. That's likely something we can look into in the future though, as it doesn't sound trivial. We'd also still want a way toe force re-build all old versions too, in case we changing theming or something. |
|
It looks like none of the solutions I proposed will actually work since both doc builds are under the same action, so it will still be marked pending, even once the latest version is built. If we disable the multiversion build in PRs, that'll resolve the issue in PRs, but will still fail on the main branch. I'll just bump the site deadline for now, and hope we find a better solution. |
Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
|
Well, I've stumbled upon an interesting discovery. Each build contains metadata used to speed-up rebuilds, but it contains a bunch of binary data that increases the build size. Deleting those files reduces the size from 75 MB to 22MB, which had the added benefit of reducing the upload time from 1m19s to 40s (total 2:51 to 2:11). There's further possible gain from removing the duplicated _static folder (~700Kb/version), but I'm not sure how that'll work between different versions, and it would require rewriting all the HTML to point to the root instead of the one it was using, so I decided not to pursue that for now. I think I'll leave that change in, though it's more of a QoL thing than a permanent fix. |
Updates the build the script to use the new API provided by the site to fetch and download artifacts.